perf(emoji): optimize FindEmojiSubmatchIndex using slice-based Trie - #38573
Merged
Conversation
Optimize the unicode emoji search function by replacing a slow and hacky strings.Replacer workaround with a custom slice-based Trie and starting-byte fast path. This improves performance by ~2.3x and eliminates all memory allocations in the common 'no-match' path. Signed-off-by: Sudhanshu Singh <sudhanshuwriterblc@gmail.com>
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Jul 22, 2026
Relocate the custom slice-based Trie structure and tests from modules/emoji to modules/util as a generic utility Signed-off-by: Sudhanshu Singh <sudhanshuwriterblc@gmail.com>
Only TrieNode/Insert/Match are used externally, so unexport trieEdge and the node fields. Extract the duplicated child-lookup loop into a child() helper, and add a keycap-emoji test covering the ASCII start-byte path. Assisted-by: Claude Code:claude-opus-4-8
silverwind
approved these changes
Jul 22, 2026
silverwind
left a comment
silverwind
left a comment
Member
There was a problem hiding this comment.
did some cleanups in 00e37e1.
GiteaBot
added
lgtm/need 1
bircni
approved these changes
Jul 22, 2026
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Jul 23, 2026
Contributor
OK, added it back and added more comments to explain the "keycap emoji" problem |
wxiaoguang
force-pushed
the
perf-emoji-trie
branch
from
July 23, 2026 07:26
be6bfe2 to
f54fa0a
Compare
wxiaoguang
force-pushed
the
perf-emoji-trie
branch
2 times, most recently
from
July 23, 2026 07:31
5b35763 to
be6bfe2
Compare
silverwind
enabled auto-merge (squash)
July 23, 2026 08:00
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to bircni/gitea
that referenced
this pull request
Jul 24, 2026
* origin/main: (21 commits) feat(setting): add shared [redis] section as default for redis-backed subsystems (go-gitea#38550) fix(webhook): remove slack channel name check (go-gitea#38608) ci: derive topic labels from PR title (go-gitea#38595) fix: download dropdown menu clipped on the branches page (go-gitea#38604) enhance(actions): action view enhancements (go-gitea#38594) enhance: keep status check list scrolled on merge box reload (go-gitea#38597) fix: make auth source group sync correctly handle team removal (go-gitea#37161) fix(oauth2): enforce mandatory 2FA policy on OAuth2 authorize/grant endpoints (go-gitea#38591) refactor: hide git repo path details from more packages (go-gitea#38601) fix(project): prevent database mutations on invalid MoveIssues payload (go-gitea#38600) refactor: retry file remove/rename when a file is busy and clean up os detection (go-gitea#38588) fix(actions): make SingleWorkflow.Marshal round-trip multi-line run blocks (stop silent job stranding) (go-gitea#38520) fix(issue): display error toast on batch action failures instead of reloading page (go-gitea#38593) perf(emoji): optimize FindEmojiSubmatchIndex using slice-based Trie (go-gitea#38573) test(e2e): add pull request merge box test, update AGENTS.md (go-gitea#38576) fix(api): align Swagger schemas for UserSettings and TopicListResponse (go-gitea#38590) fix(file-tree): handle submodule links and missing view container (go-gitea#38033) refactor: clean up git repo and model migration packages (go-gitea#38564) [skip ci] Updated translations via Crowdin fix(actions): fail unexpandable reusable workflow callers and decouple the job emitter's cross-run processing (go-gitea#38565) ... # Conflicts: # services/actions/reusable_workflow_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request optimizes
FindEmojiSubmatchIndexin Gitea's emoji package (modules/emoji/emoji.go) by replacing thestrings.Replacer-based search with a slice-based trie and a constant-time starting-byte check (isStartingByte).The new implementation avoids heap allocations during the search and reduces CPU overhead when rendering Markdown, particularly for plain text that does not contain emojis.
Verification
Verified with unit tests:
go test -count=1 ./modules/emoji/...Benchmarks:
go test -bench=. -benchmem ./modules/emoji/...Results
BenchmarkFindEmojiSubmatchIndexBenchmarkFindEmojiSubmatchIndexNoMatchBenchmark Output